From: Jonathan Dieter <jdieter@gmail.com>
Date: Fri, 14 Sep 2018 12:21:58 +0000 (+0100)
Subject: Fix memory leak
X-Git-Tag: archive/raspbian/1.1.9+ds1-1+rpi1~1^2~124
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=50e9d1ed5448ba44adc427749ae9094c58c99b0d;p=zchunk.git

Fix memory leak
(Coverity ID: 310910)

Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
---

diff --git a/src/lib/index/index_read.c b/src/lib/index/index_read.c
index 136c1bd..2754750 100644
--- a/src/lib/index/index_read.c
+++ b/src/lib/index/index_read.c
@@ -24,6 +24,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
+#include <assert.h>
 #include <stdlib.h>
 #include <stdint.h>
 #include <stdbool.h>
@@ -67,19 +68,12 @@ bool index_read(zckCtx *zck, char *data, size_t size, size_t max_length) {
         }
 
         zckChunk *new = zmalloc(sizeof(zckChunk));
-        if(!new) {
-            set_fatal_error(zck, "Unable to allocate %lu bytes",
-                            sizeof(zckChunk));
-            return false;
-        }
+        assert(new);
 
         /* Read index entry digest */
         new->digest = zmalloc(zck->index.digest_size);
-        if(!new->digest) {
-            set_fatal_error(zck, "Unable to allocate %lu bytes",
-                                 zck->index.digest_size);
-            return false;
-        }
+        assert(new->digest);
+
         memcpy(new->digest, data+length, zck->index.digest_size);
         new->digest_size = zck->index.digest_size;
         length += zck->index.digest_size;