From: Jérémy Lal Date: Fri, 8 Nov 2024 19:05:21 +0000 (+0100) Subject: do not use dns.ADDRCONFIG for localhost X-Git-Tag: archive/raspbian/20.18.0+dfsg-2+rpi1^2~18 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=4e46523166e5e8ab7df5c2bb1db4e7f1be5f7435;p=nodejs.git do not use dns.ADDRCONFIG for localhost Last-Update: 2020-06-11 Bug-Debian: https://bugs.debian.org/962318 Forwarded: https://github.com/nodejs/node/issues/33816 it fails on IPv6-only systems. Setting it with libc fails on linux. https://github.com/nodejs/node/issues/33279 https://lists.debian.org/debian-devel/2023/12/msg00011.html Gbp-Pq: Topic deps Gbp-Pq: Name localhost-no-addrconfig.patch --- diff --git a/lib/net.js b/lib/net.js index 6fe798e0f..a25bd32f6 100644 --- a/lib/net.js +++ b/lib/net.js @@ -1,4 +1,5 @@ // Copyright Joyent, Inc. and other Node contributors. + // // Permission is hereby granted, free of charge, to any person obtaining a // copy of this software and associated documentation files (the @@ -1339,13 +1340,6 @@ function lookupAndConnect(self, options) { hints: options.hints || 0, }; - if (!isWindows && - dnsopts.family !== 4 && - dnsopts.family !== 6 && - dnsopts.hints === 0) { - dnsopts.hints = dns.ADDRCONFIG; - } - debug('connect: find host', host); debug('connect: dns options', dnsopts); self._host = host; diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 2514c3206..e85f456f6 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -24,6 +24,10 @@ test-worker-heapsnapshot-options : PASS,FLAKY # https://github.com/nodejs/node/issues/24403 test-cli-syntax: PASS,FLAKY +# does not work on IPv6 only host +test-tls-psk-client: PASS,FLAKY +test-tls-securepair-client: PASS,FLAKY + [$system==win32] # https://github.com/nodejs/node/issues/47116 test-http-max-sockets: PASS, FLAKY