From: François Cartegnie <fcvlcdev@free.fr>
Date: Wed, 2 Sep 2020 14:53:13 +0000 (+0200)
Subject: meta: taglib: reject non expected schemes
X-Git-Tag: archive/raspbian/3.0.21-7+rpi1^2~84
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=49f8845db3d3789b6b1c4fe2d4bd4909a66f15c1;p=vlc.git

meta: taglib: reject non expected schemes

refs #25035

(cherry picked from commit 8191ac5727a3525a6bee99e1674167a7894f9ccb) (rebased)
rebased:
- 3.0 already has a26e2ba370d898dda04c718176af7d2e329dab7a above

Gbp-Pq: Name 0042-meta-taglib-reject-non-expected-schemes.patch
---

diff --git a/modules/meta_engine/taglib.cpp b/modules/meta_engine/taglib.cpp
index 0b7b5820..ced4f56b 100644
--- a/modules/meta_engine/taglib.cpp
+++ b/modules/meta_engine/taglib.cpp
@@ -910,6 +910,23 @@ static int ReadWAVMeta( const RIFF::WAV::File *wav, demux_meta_t *demux_meta )
     return VLC_SUCCESS;
 }
 
+static bool isSchemeCompatible( const char *psz_uri )
+{
+    const char *p = strstr( psz_uri, "://" );
+    if( p == NULL )
+        return false;
+
+    size_t i_len = p - psz_uri;
+    const char * compatibleschemes[] =
+    {
+        "file", "smb",
+    };
+    for( size_t i=0; i<ARRAY_SIZE(compatibleschemes); i++ )
+        if( !strncasecmp( psz_uri, compatibleschemes[i], i_len ) )
+            return true;
+    return false;
+}
+
 /**
  * Get the tags from the file using TagLib
  * @param p_this: the demux object
@@ -928,6 +945,12 @@ static int ReadMeta( vlc_object_t* p_this)
     if( unlikely(psz_uri == NULL) )
         return VLC_ENOMEM;
 
+    if( !isSchemeCompatible( psz_uri ) )
+    {
+        free( psz_uri );
+        return VLC_EGENERIC;
+    }
+
     if( !b_extensions_registered )
     {
 #if TAGLIB_VERSION >= TAGLIB_VERSION_1_11