From: Juergen Gross Date: Wed, 25 May 2022 10:55:49 +0000 (+0200) Subject: tools/xenstore: fix event sending in introduce_domain() X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~611 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=49dd52fb1311dadab29f6634d0bc1f4c022c357a;p=xen.git tools/xenstore: fix event sending in introduce_domain() Commit fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") introduced a potential NULL dereference in case of Xenstore live update. Fix that by adding an appropriate check. Coverity-Id: 1504572 Fixes: fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") Signed-off-by: Juergen Gross Reviewed-by: Andrew Cooper --- diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index de88bf2a68..ead4c237d2 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -493,9 +493,11 @@ static struct domain *introduce_domain(const void *ctx, /* Now domain belongs to its connection. */ talloc_steal(domain->conn, domain); - /* Notify the domain that xenstore is available */ - interface->connection = XENSTORE_CONNECTED; - xenevtchn_notify(xce_handle, domain->port); + if (!restore) { + /* Notify the domain that xenstore is available */ + interface->connection = XENSTORE_CONNECTED; + xenevtchn_notify(xce_handle, domain->port); + } if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL,