From: Ian Campbell <ian.campbell@citrix.com>
Date: Wed, 15 Jul 2015 12:14:41 +0000 (+0100)
Subject: tools: libxl: check errors from libxl_create_logfile for stubdom log
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~2764
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=47e4d26f2983b82141cdd2f96199b03bcfb526d6;p=xen.git

tools: libxl: check errors from libxl_create_logfile for stubdom log

Spotted by Coverity after the recent similar fix to
libxl__create_qemu_logfile.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 19fb2e408d..634b8d2d66 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -1258,7 +1258,8 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
             case STUBDOM_CONSOLE_LOGGING:
                 name = libxl__sprintf(gc, "qemu-dm-%s",
                                       libxl_domid_to_name(ctx, guest_domid));
-                libxl_create_logfile(ctx, name, &filename);
+                ret = libxl_create_logfile(ctx, name, &filename);
+                if (ret) goto out;
                 console[i].output = libxl__sprintf(gc, "file:%s", filename);
                 free(filename);
                 break;