From: Keir Fraser Date: Fri, 4 Jun 2010 09:09:59 +0000 (+0100) Subject: xl: fix network-attach command line parsing X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~12025 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=46d24c4a83408ec4b32af4243606de89b5984e5c;p=xen.git xl: fix network-attach command line parsing Command line arguments start at argv[2]. Signed-off-by: Jeremy Fitzhardinge --- diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 03eafbf45e..f29d3ceaad 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -3380,11 +3380,11 @@ int main_networkattach(int argc, char **argv) int i; unsigned int val; - if ((argc < 2) || (argc > 11)) { + if ((argc < 3) || (argc > 11)) { help("network-attach"); exit(0); } - while ((opt = getopt(argc, argv, "hl")) != -1) { + while ((opt = getopt(argc, argv, "h")) != -1) { switch (opt) { case 'h': help("network-attach"); @@ -3395,12 +3395,12 @@ int main_networkattach(int argc, char **argv) } } - if (domain_qualifier_to_domid(argv[1], &domid, 0) < 0) { - fprintf(stderr, "%s is an invalid domain identifier\n", argv[1]); + if (domain_qualifier_to_domid(argv[2], &domid, 0) < 0) { + fprintf(stderr, "%s is an invalid domain identifier\n", argv[2]); exit(1); } init_nic_info(&nic, -1); - for (argv += 2, argc -= 2; argc > 0; ++argv, --argc) { + for (argv += 3, argc -= 3; argc > 0; ++argv, --argc) { if (!strncmp("type=", *argv, 5)) { if (!strncmp("vif", (*argv) + 5, 4)) { nic.nictype = NICTYPE_VIF;