From: Juergen Gross Date: Tue, 2 Aug 2016 17:25:42 +0000 (+0200) Subject: libxl: use llabs() instead abs() for int64_t argument X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~641 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=45a348ebaba3f6e0a26455a3ff181a41722943a0;p=xen.git libxl: use llabs() instead abs() for int64_t argument Commit 57f8b13c724023c78fa15a80452d1de3e51a1418 ("libxl: memory size in kb requires 64 bit variable") introduced a bug: abs() shouldn't be called with an int64_t argument. llabs() is to be used here. Caught by clang build with error message: libxl.c:4198:33: error: absolute value function 'abs' given an argument of type 'int64_t' (aka 'long') but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value] if (target_memkb < 0 && abs(target_memkb) > current_target_memkb) Signed-off-by: Juergen Gross Acked-by: Wei Liu --- diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index de8f058db3..7bd3e8ccac 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -4195,7 +4195,7 @@ retry_transaction: videoram = videoram_s ? atoi(videoram_s) : 0; if (relative) { - if (target_memkb < 0 && abs(target_memkb) > current_target_memkb) + if (target_memkb < 0 && llabs(target_memkb) > current_target_memkb) new_target_memkb = 0; else new_target_memkb = current_target_memkb + target_memkb;