From: Carlos Garnacho <carlosg@gnome.org>
Date: Fri, 8 Jun 2018 11:31:32 +0000 (+0200)
Subject: gtkentrycompletion: Properly remove controller from entry
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~22^2~15
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=419ee6a4512ecae10a91c537a1a10bc11bfdc23e;p=gtk4.git

gtkentrycompletion: Properly remove controller from entry

When disconnecting the GtkEntry from the GtkEntryCompletion, we
must remove the controller in order to avoid dangling callbacks.
---

diff --git a/gtk/gtkentrycompletion.c b/gtk/gtkentrycompletion.c
index ef25764fc1..af90772162 100644
--- a/gtk/gtkentrycompletion.c
+++ b/gtk/gtkentrycompletion.c
@@ -2448,9 +2448,10 @@ completion_insert_text_callback (GtkEntry           *entry,
 static void
 connect_completion_signals (GtkEntryCompletion *completion)
 {
+  GtkEntryCompletionPrivate *priv = completion->priv;
   GtkEventController *controller;
 
-  controller = gtk_event_controller_key_new ();
+  controller = priv->entry_key_controller = gtk_event_controller_key_new ();
   g_signal_connect (controller, "key-pressed",
                     G_CALLBACK (gtk_entry_completion_key_pressed), completion);
   g_signal_connect_swapped (controller, "focus-out",
@@ -2504,6 +2505,9 @@ unset_accessible_relation (GtkWidget *window,
 static void
 disconnect_completion_signals (GtkEntryCompletion *completion)
 {
+  gtk_widget_remove_controller (completion->priv->entry,
+                                completion->priv->entry_key_controller);
+
   if (completion->priv->changed_id > 0 &&
       g_signal_handler_is_connected (completion->priv->entry,
                                      completion->priv->changed_id))