From: Jan Beulich <jbeulich@suse.com>
Date: Thu, 22 Jun 2017 07:52:32 +0000 (+0200)
Subject: x86: fold identical error paths in xenmem_add_to_physmap_one()
X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~1942
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=4149c9af7cf671e57717ce75e9924dc779c02109;p=xen.git

x86: fold identical error paths in xenmem_add_to_physmap_one()

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 19050d62b4..e0abff00fd 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4887,11 +4887,8 @@ int xenmem_add_to_physmap_one(
 
     if ( !paging_mode_translate(d) || (mfn == 0) )
     {
-        if ( page )
-            put_page(page);
-        if ( space == XENMAPSPACE_gmfn || space == XENMAPSPACE_gmfn_range )
-            put_gfn(d, gfn);
-        return -EINVAL;
+        rc = -EINVAL;
+        goto put_both;
     }
 
     /* Remove previously mapped page if it was present. */