From: Matthias Clasen <mclasen@redhat.com>
Date: Tue, 7 Jul 2015 01:59:10 +0000 (-0400)
Subject: place sidebar: minor change
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~24^2~9117
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=3cbe6d86aff9a58431c529d40f0a932ce575c4c2;p=gtk4.git

place sidebar: minor change

We generally prefer for loops to iterate over lists.
---

diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index 5f92fac93b..54271df828 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -2317,9 +2317,9 @@ rename_entry_changed (GtkEntry         *entry,
       gtk_label_set_label (GTK_LABEL (sidebar->rename_error), "");
       return;
     }
+
   rows = gtk_container_get_children (GTK_CONTAINER (sidebar->list_box));
-  l = rows;
-  while (l != NULL && !found)
+  for (l = rows; l && !found; l = l->next)
     {
       g_object_get (l->data,
                     "place-type", &type,
@@ -2334,15 +2334,12 @@ rename_entry_changed (GtkEntry         *entry,
 
       g_free (uri);
       g_free (name);
-
-      l = l->next;
     }
+  g_list_free (rows);
 
   gtk_widget_set_sensitive (sidebar->rename_button, !found);
   gtk_label_set_label (GTK_LABEL (sidebar->rename_error),
                        found ? _("This name is already taken") : "");
-
-  g_list_free (rows);
 }
 
 static void