From: OpenJDK Team Date: Thu, 2 Nov 2023 10:23:27 +0000 (+0100) Subject: Misalign address in the test rather than structure X-Git-Tag: archive/raspbian/17.0.9+9-2+rpi1^2~7 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=390f5f9529f2113627a4c3e7345e1805b086b3b3;p=openjdk-17.git Misalign address in the test rather than structure mk68-support.diff aligned metaspace structures by 4 bytes breaking the test. Add 1 to address type rather than aligned structure to produce misaligned pointer. Gbp-Pq: Name misalign-pointer-for-armhf.patch --- diff --git a/test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp b/test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp index d96f57d29..38ba9fcda 100644 --- a/test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp +++ b/test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp @@ -61,7 +61,7 @@ public: ASSERT_TRUE(MetaspaceObj::is_valid(p)); // A misaligned object shall not be recognized - const MetaspaceObj* p_misaligned = (MetaspaceObj*)((address)p) + 1; + const MetaspaceObj* p_misaligned = (MetaspaceObj*)((address)p + 1); ASSERT_FALSE(MetaspaceObj::is_valid(p_misaligned)); // Test VirtualSpaceList::contains @@ -72,7 +72,7 @@ public: ASSERT_TRUE(vslist->contains((MetaWord*)p)); // A misaligned pointer shall still be recognized by list::contains - ASSERT_TRUE(vslist->contains((MetaWord*)((address)p) + 1)); + ASSERT_TRUE(vslist->contains((MetaWord*)((address)p + 1))); // Now for some bogus values ASSERT_FALSE(MetaspaceObj::is_valid((MetaspaceObj*)NULL));