From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Mon, 13 Mar 2023 14:03:28 +0000 (+0100)
Subject: Use NKError extension properties instead of magic numbers in FileProviderEnumerator
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~96^2^2~55^2~124
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=3873ad126d6eba0d43d20222cc3d081478abba93;p=nextcloud-desktop.git

Use NKError extension properties instead of magic numbers in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift b/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift
index 40f7f8428..9a8d8f45b 100644
--- a/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift
+++ b/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift
@@ -103,7 +103,7 @@ class FileProviderEnumerator: NSObject, NSFileProviderEnumerator {
                         guard readError == nil else {
                             NSLog("Finishing enumeration of working set directory %@ with error %@", directoryMetadata.serverUrl, readError!.localizedDescription)
 
-                            if let nkReadError = readError as? NKError, nkReadError.errorCode == 404 {
+                            if let nkReadError = readError as? NKError, nkReadError.isNotFoundError {
                                 NSLog("404 error means item no longer exists. Deleting metadata and reporting as deletion without error")
                                 dbManager.deleteDirectoryAndSubdirectoriesMetadata(ocId: directoryMetadata.ocId)
                             }
@@ -244,7 +244,7 @@ class FileProviderEnumerator: NSObject, NSFileProviderEnumerator {
                 if let nkReadError = readError as? NKError {
                     let fpError = nkReadError.toFileProviderError()
 
-                    if nkReadError.errorCode == 404 {
+                    if nkReadError.isNotFoundError {
                         NSLog("404 error means item no longer exists. Deleting metadata and reporting %@ as deletion without error", self.serverUrl)
 
                         guard let itemMetadata = self.enumeratedItemMetadata else {
@@ -416,7 +416,7 @@ class FileProviderEnumerator: NSObject, NSFileProviderEnumerator {
                 NSLog("Finishing enumeration of changes at %@ with error %@", directoryMetadata.serverUrl, readError!.localizedDescription)
 
                 if let nkReadError = readError as? NKError {
-                    if nkReadError.errorCode == 404 {
+                    if nkReadError.isNotFoundError {
                         NSLog("404 error means item no longer exists. Deleting metadata and reporting as deletion without error")
 
                         guard let directoryItemMetadata = dbManager.itemMetadataFromOcId(directoryMetadata.ocId) else {