From: Alice Mikhaylenko <alexm@gnome.org>
Date: Sun, 7 May 2023 11:21:16 +0000 (+0400)
Subject: modelbutton: Fix a use after free when unsetting accel
X-Git-Tag: archive/raspbian/4.12.3+ds-1+rpi1~1^2^2^2~22^2~1^2~298^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=380b63fedeb34a46351f9d9351ce64f702a4019d;p=gtk4.git

modelbutton: Fix a use after free when unsetting accel

gtk_widget_remove_controller() already destroys the controller.
---

diff --git a/gtk/gtkmodelbutton.c b/gtk/gtkmodelbutton.c
index a296e6119c..cd8052fe84 100644
--- a/gtk/gtkmodelbutton.c
+++ b/gtk/gtkmodelbutton.c
@@ -877,7 +877,7 @@ update_accel (GtkModelButton *self,
       if (self->controller)
         {
           gtk_widget_remove_controller (GTK_WIDGET (self), GTK_EVENT_CONTROLLER (self->controller));
-          g_clear_object (&self->controller);
+          self->controller = NULL;
         }
     }
 }