From: Colin Walters <walters@verbum.org>
Date: Thu, 21 Sep 2017 15:00:09 +0000 (-0400)
Subject: lib/repo: Move alloca() outside of loop
X-Git-Tag: archive/raspbian/2022.1-3+rpi1~1^2~4^2~31^2~54
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=3767ac4ad83d0d0c720d68603f65bfd9a0ebb006;p=ostree.git

lib/repo: Move alloca() outside of loop

Just noticed this while looking at the code for a different issue.

Closes: #1201
Approved by: jlebon
---

diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c
index 0056d805..e04a1b6a 100644
--- a/src/libostree/ostree-repo.c
+++ b/src/libostree/ostree-repo.c
@@ -5179,11 +5179,11 @@ _ostree_repo_allocate_tmpdir (int tmpdir_dfd,
       ret_tmpdir.initialized = TRUE;
     }
 
+  const char *tmpdir_name_template = glnx_strjoina (tmpdir_prefix, "XXXXXX");
   while (!ret_tmpdir.initialized)
     {
       g_auto(GLnxTmpDir) new_tmpdir = { 0, };
       /* No existing tmpdir found, create a new */
-      const char *tmpdir_name_template = glnx_strjoina (tmpdir_prefix, "XXXXXX");
       if (!glnx_mkdtempat (tmpdir_dfd, tmpdir_name_template, 0755,
                            &new_tmpdir, error))
         return FALSE;