From: Olivier Goffart Date: Tue, 15 Nov 2016 12:58:18 +0000 (+0100) Subject: Rename SyncFileStatus::sharedWithMe to shared X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~1015 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=2f3db04e87a4e3edff389389d46d1c7a5a3e0d03;p=nextcloud-desktop.git Rename SyncFileStatus::sharedWithMe to shared Last commit for issue #4788 made the meaning to be simply shared (with the user or from the user) --- diff --git a/src/libsync/syncfilestatus.cpp b/src/libsync/syncfilestatus.cpp index c81a64745..169be2bc8 100644 --- a/src/libsync/syncfilestatus.cpp +++ b/src/libsync/syncfilestatus.cpp @@ -17,12 +17,12 @@ namespace OCC { SyncFileStatus::SyncFileStatus() - :_tag(StatusNone), _sharedWithMe(false) + :_tag(StatusNone), _shared(false) { } SyncFileStatus::SyncFileStatus(SyncFileStatusTag tag) - :_tag(tag), _sharedWithMe(false) + :_tag(tag), _shared(false) { } @@ -37,14 +37,14 @@ SyncFileStatus::SyncFileStatusTag SyncFileStatus::tag() const return _tag; } -void SyncFileStatus::setSharedWithMe(bool isShared) +void SyncFileStatus::setShared(bool isShared) { - _sharedWithMe = isShared; + _shared = isShared; } -bool SyncFileStatus::sharedWithMe() const +bool SyncFileStatus::shared() const { - return _sharedWithMe; + return _shared; } QString SyncFileStatus::toSocketAPIString() const @@ -72,7 +72,7 @@ QString SyncFileStatus::toSocketAPIString() const statusString = QLatin1String("ERROR"); break; } - if(canBeShared && _sharedWithMe) { + if(canBeShared && _shared) { statusString += QLatin1String("+SWM"); } diff --git a/src/libsync/syncfilestatus.h b/src/libsync/syncfilestatus.h index 83a658ce3..6fda24c16 100644 --- a/src/libsync/syncfilestatus.h +++ b/src/libsync/syncfilestatus.h @@ -43,18 +43,18 @@ public: void set(SyncFileStatusTag tag); SyncFileStatusTag tag() const; - void setSharedWithMe( bool isShared ); - bool sharedWithMe() const; + void setShared( bool isShared ); + bool shared() const; QString toSocketAPIString() const; private: SyncFileStatusTag _tag; - bool _sharedWithMe; + bool _shared; }; inline bool operator==(const SyncFileStatus &a, const SyncFileStatus &b) { - return a.tag() == b.tag() && a.sharedWithMe() == b.sharedWithMe(); + return a.tag() == b.tag() && a.shared() == b.shared(); } inline bool operator!=(const SyncFileStatus &a, const SyncFileStatus &b) { diff --git a/src/libsync/syncfilestatustracker.cpp b/src/libsync/syncfilestatustracker.cpp index 6ca41e219..b7c26bb5c 100644 --- a/src/libsync/syncfilestatustracker.cpp +++ b/src/libsync/syncfilestatustracker.cpp @@ -272,7 +272,7 @@ SyncFileStatus SyncFileStatusTracker::resolveSyncAndErrorStatus(const QString &r } if (isShared) - status.setSharedWithMe(true); + status.setShared(true); return status; } diff --git a/test/testsyncfilestatustracker.cpp b/test/testsyncfilestatustracker.cpp index 32cba399d..897d47a97 100644 --- a/test/testsyncfilestatustracker.cpp +++ b/test/testsyncfilestatustracker.cpp @@ -371,7 +371,7 @@ private slots: void sharedStatus() { SyncFileStatus sharedUpToDateStatus(SyncFileStatus::StatusUpToDate); - sharedUpToDateStatus.setSharedWithMe(true); + sharedUpToDateStatus.setShared(true); FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()}; fakeFolder.remoteModifier().insert("S/s0"); @@ -399,7 +399,7 @@ private slots: QEXPECT_FAIL("", "We currently only know if a new file is shared on the second sync, after a PROPFIND.", Continue); QCOMPARE(statusSpy.statusOf("S/s0"), sharedUpToDateStatus); QCOMPARE(statusSpy.statusOf("S/s1"), sharedUpToDateStatus); - QCOMPARE(statusSpy.statusOf("B/b1").sharedWithMe(), false); + QCOMPARE(statusSpy.statusOf("B/b1").shared(), false); QCOMPARE(statusSpy.statusOf("B/b3"), sharedUpToDateStatus); QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());