From: Michael Orlitzky <michael@orlitzky.com>
Date: Mon, 28 Aug 2023 19:27:46 +0000 (-0400)
Subject: testsuite/gsk: add explicit dimensions to <svg> elements
X-Git-Tag: archive/raspbian/4.12.4+ds-3+rpi1^2~21^2~2^2~36
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=2eb61946044de04bf487b5b97ccbf5e0b6e38fd5;p=gtk4.git

testsuite/gsk: add explicit dimensions to <svg> elements

Without an explicit width, height, and viewBox, there is no single
correct way to render an SVG. In the absense of said information,
librsvg is capable of making a guess by rendering the SVG to a Cairo
surface and then analyzing that surface; however, this process is
merely heuristic.

There are three GTK tests for SVG images that are missing dimensions.
While this is not a violation of the SVG specification, it does
implicitly couple the test to the librsvg rendering heuristic. In this
commit we add that dimension information so that the expected result
is unambiguous.
---

diff --git a/testsuite/gsk/compare/texture-scale-stripes.node b/testsuite/gsk/compare/texture-scale-stripes.node
index acd72b2e44..8f25c1deed 100644
--- a/testsuite/gsk/compare/texture-scale-stripes.node
+++ b/testsuite/gsk/compare/texture-scale-stripes.node
@@ -3,6 +3,6 @@ clip {
   child: texture-scale {
     bounds: 0 0 19991 19991;
     filter: nearest;
-    texture: url('data:,<svg><rect width="10" height="10" style="fill:red" /></svg>');
+    texture: url('data:,<svg width="10" height="10" viewBox="0 0 10 10"><rect width="10" height="10" style="fill:red" /></svg>');
   }
 }
\ No newline at end of file
diff --git a/testsuite/gsk/compare/texture-url.node b/testsuite/gsk/compare/texture-url.node
index f31bf02610..25f0a164b4 100644
--- a/testsuite/gsk/compare/texture-url.node
+++ b/testsuite/gsk/compare/texture-url.node
@@ -7,5 +7,5 @@ color {
 
 texture {
   bounds: 10 10 30 30;
-  texture: url('data:,<svg><rect width="10" height="10" style="fill:red"/></svg>');
+  texture: url('data:,<svg width="10" height="10" viewBox="0 0 10 10"><rect width="10" height="10" style="fill:red"/></svg>');
 }
diff --git a/testsuite/gsk/nodeparser/texture-scale-filters.node b/testsuite/gsk/nodeparser/texture-scale-filters.node
index 1aef466ce5..0bffe49ed0 100644
--- a/testsuite/gsk/nodeparser/texture-scale-filters.node
+++ b/testsuite/gsk/nodeparser/texture-scale-filters.node
@@ -1,22 +1,22 @@
 texture-scale {
-  texture: url('data:,<svg><rect width="10" height="10" style="fill:red"/></svg>');
+  texture: url('data:,<svg width="10" height="10" viewBox="0 0 10 10"><rect width="10" height="10" style="fill:red"/></svg>');
   bounds: 0 0 50 50;
 }
 
 texture-scale {
-  texture: url('data:,<svg><rect width="10" height="10" style="fill:red"/></svg>');
+  texture: url('data:,<svg width="10" height="10" viewBox="0 0 10 10"><rect width="10" height="10" style="fill:red"/></svg>');
   bounds: 0 0 50 50;
   filter: linear;
 }
 
 texture-scale {
-  texture: url('data:,<svg><rect width="10" height="10" style="fill:red"/></svg>');
+  texture: url('data:,<svg width="10" height="10" viewBox="0 0 10 10"><rect width="10" height="10" style="fill:red"/></svg>');
   bounds: 0 0 50 50;
   filter: nearest;
 }
 
 texture-scale {
-  texture: url('data:,<svg><rect width="10" height="10" style="fill:red"/></svg>');
+  texture: url('data:,<svg width="10" height="10" viewBox="0 0 10 10"><rect width="10" height="10" style="fill:red"/></svg>');
   bounds: 0 0 50 50;
   filter: trilinear;
 }