From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Fri, 11 Nov 2022 12:11:33 +0000 (+0100)
Subject: Clean up declarations in ClientSideEncryption
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~11^2~30^2~22
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=2c4dc7e231b22d4c437147cefb177c7b885412f6;p=nextcloud-desktop.git

Clean up declarations in ClientSideEncryption

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/src/libsync/clientsideencryption.h b/src/libsync/clientsideencryption.h
index 664e92ad3..1783ebba5 100644
--- a/src/libsync/clientsideencryption.h
+++ b/src/libsync/clientsideencryption.h
@@ -119,48 +119,46 @@ public:
     class PKey;
 
     ClientSideEncryption();
-    void initialize(const AccountPtr &account);
 
-private:
-    void generateKeyPair(const AccountPtr &account);
-    void generateCSR(const AccountPtr &account, PKey keyPair);
-    void sendSignRequestCSR(const AccountPtr &account, PKey keyPair, const QByteArray &csrContent);
-    void encryptPrivateKey(const AccountPtr &account);
+    QByteArray _privateKey;
+    QSslKey _publicKey;
+    QSslCertificate _certificate;
+    QString _mnemonic;
+    bool _newMnemonicGenerated = false;
 
-public:
+signals:
+    void initializationFinished(bool isNewMnemonicGenerated = false);
+
+public slots:
+    void initialize(const AccountPtr &account);
     void forgetSensitiveData(const AccountPtr &account);
 
 private slots:
+    void generateKeyPair(const AccountPtr &account);
+    void encryptPrivateKey(const AccountPtr &account);    
+
     void publicKeyFetched(QKeychain::Job *incoming);
     void privateKeyFetched(QKeychain::Job *incoming);
     void mnemonicKeyFetched(QKeychain::Job *incoming);
 
-signals:
-    void initializationFinished(bool isNewMnemonicGenerated = false);
-
-private:
     void getPrivateKeyFromServer(const AccountPtr &account);
     void getPublicKeyFromServer(const AccountPtr &account);
     void fetchAndValidatePublicKeyFromServer(const AccountPtr &account);
     void decryptPrivateKey(const AccountPtr &account, const QByteArray &key);
 
     void fetchFromKeyChain(const AccountPtr &account);
-
-    [[nodiscard]] bool checkPublicKeyValidity(const AccountPtr &account) const;
-    [[nodiscard]] bool checkServerPublicKeyValidity(const QByteArray &serverPublicKeyString) const;
     void writePrivateKey(const AccountPtr &account);
     void writeCertificate(const AccountPtr &account);
     void writeMnemonic(const AccountPtr &account);
 
-    bool isInitialized = false;
+private:
+    void generateCSR(const AccountPtr &account, PKey keyPair);
+    void sendSignRequestCSR(const AccountPtr &account, PKey keyPair, const QByteArray &csrContent);
 
-public:
-    //QSslKey _privateKey;
-    QByteArray _privateKey;
-    QSslKey _publicKey;
-    QSslCertificate _certificate;
-    QString _mnemonic;
-    bool _newMnemonicGenerated = false;
+    [[nodiscard]] bool checkPublicKeyValidity(const AccountPtr &account) const;
+    [[nodiscard]] bool checkServerPublicKeyValidity(const QByteArray &serverPublicKeyString) const;
+
+    bool isInitialized = false;
 };
 
 /* Generates the Metadata for the folder */