From: Colin Walters <walters@verbum.org>
Date: Thu, 14 Dec 2023 13:03:01 +0000 (-0500)
Subject: zipl: NUL terminate buffer we're searching
X-Git-Tag: archive/raspbian/2024.8-1+rpi1^2~7^2~7^2~12^2~1
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=241597a8a5bbc4223d7739ffe191e5114af40caa;p=ostree.git

zipl: NUL terminate buffer we're searching

Found by a static analyzer.
---

diff --git a/src/libostree/ostree-bootloader-zipl.c b/src/libostree/ostree-bootloader-zipl.c
index d6fb7ebd..0329eb65 100644
--- a/src/libostree/ostree-bootloader-zipl.c
+++ b/src/libostree/ostree-bootloader-zipl.c
@@ -149,9 +149,10 @@ _ostree_secure_boot_is_enabled (gboolean *out_enabled, GCancellable *cancellable
   while (*out_enabled != TRUE && max_lines > 0)
     {
       char buf[1024];
-      ssize_t len = TEMP_FAILURE_RETRY (read (fd, buf, sizeof (buf)));
+      ssize_t len = TEMP_FAILURE_RETRY (read (fd, buf, sizeof (buf) - 1));
       if (len < 0)
         break;
+      buf[len] = '\0';
       *out_enabled = strstr (buf, "Secure-IPL enabled") != NULL;
       --max_lines;
     }