From: Denis Pynkin <denis.pynkin@collabora.com>
Date: Mon, 17 Feb 2020 21:46:51 +0000 (+0300)
Subject: sign-dummy: optimize ostree_sign_dummy_data_verify
X-Git-Tag: archive/raspbian/2022.1-3+rpi1~1^2~4^2~10^2~73^2~5
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=1e3bdef2851260b8ac3503744d4157d527e3823d;p=ostree.git

sign-dummy: optimize ostree_sign_dummy_data_verify

Return TRUE as soon as any signature verified.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
---

diff --git a/src/libostree/ostree-sign-dummy.c b/src/libostree/ostree-sign-dummy.c
index b9d8abf4..722d461b 100644
--- a/src/libostree/ostree-sign-dummy.c
+++ b/src/libostree/ostree-sign-dummy.c
@@ -156,7 +156,6 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self,
   if (!g_variant_is_of_type (signatures, (GVariantType *) OSTREE_SIGN_METADATA_DUMMY_TYPE))
     return glnx_throw (error, "signature: dummy: wrong type passed for verification");
 
-  gboolean verified = FALSE;
   for (gsize i = 0; i < g_variant_n_children(signatures); i++)
     {
       g_autoptr (GVariant) child = g_variant_get_child_value (signatures, i);
@@ -169,12 +168,10 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self,
       g_debug("Stored signature %d: %s", (gint)i, sign->pk_ascii);
 
       if (!g_strcmp0(sign_ascii, sign->pk_ascii))
-        verified = TRUE;
+        return TRUE;
       else
         return glnx_throw (error, "signature: dummy: incorrect signature %" G_GSIZE_FORMAT, i);
     }
-  if (!verified)
-    return glnx_throw (error, "signature: dummy: no signatures");
 
-  return TRUE;
+  return glnx_throw (error, "signature: dummy: no signatures");
 }