From: Rui Matos <tiagomatos@gmail.com>
Date: Tue, 17 Oct 2017 15:17:55 +0000 (+0200)
Subject: compositor: Avoid a crash if the top window actor is finalized
X-Git-Tag: archive/raspbian/3.28.1-1+rpi1~2^2^2^2^2~3
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=1dd95c31ffb3837ec1244614b7c1296882cc9d61;p=mutter.git

compositor: Avoid a crash if the top window actor is finalized

Since we're not holding a reference, the top window actor might be
finalized when we paint resulting in a use after free crash.

https://bugzilla.gnome.org/show_bug.cgi?id=788493

Gbp-Pq: Name 0017-compositor-Avoid-a-crash-if-top-window-finalized.patch
---

diff --git a/src/compositor/compositor.c b/src/compositor/compositor.c
index a75ac12..1d5b9ab 100644
--- a/src/compositor/compositor.c
+++ b/src/compositor/compositor.c
@@ -671,6 +671,9 @@ meta_compositor_remove_window (MetaCompositor *compositor,
   if (compositor->unredirected_window == window)
     set_unredirected_window (compositor, NULL);
 
+  if (compositor->top_window_actor == window_actor)
+    compositor->top_window_actor = NULL;
+
   meta_window_actor_destroy (window_actor);
 }