From: Juergen Gross Date: Fri, 23 Mar 2018 07:42:53 +0000 (+0100) Subject: tools/xenstore: fix linking libxenstore with ldl X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~323 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=1a373194922bc73ab4113eb4d5550e5dc922782b;p=xen.git tools/xenstore: fix linking libxenstore with ldl Commit 448c03b3cbe1487 ("tools/xenstore: try to get minimum thread stack size for watch thread") added a dependency to libdl to libxenstore. Unfortunately the way it was added requires now all users of libxenstore to specify "-ldl" when linking. This can be avoided by linking libxenstore.so specifying "-ldl" as a trailing option. So use APPEND_LDFLAGS instead of LDFLAGS for adding the "-ldl" option when linking libxenstore.so. Signed-off-by: Juergen Gross Reviewed-by: Doug Goldstein Tested-by: Doug Goldstein Acked-by: Wei Liu --- diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile index 69e55e73e5..445e9911b2 100644 --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -104,7 +104,7 @@ libxenstore.so.$(MAJOR): libxenstore.so.$(MAJOR).$(MINOR) xs.opic: CFLAGS += -DUSE_PTHREAD ifeq ($(CONFIG_Linux),y) xs.opic: CFLAGS += -DUSE_DLSYM -libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl +libxenstore.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += -ldl else PKG_CONFIG_REMOVE += -ldl endif