From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Thu, 14 Feb 2019 01:59:13 +0000 (+0900)
Subject: login: add a missing error check for session_set_leader()
X-Git-Tag: archive/raspbian/241-7_deb10u2+rpi1^2~20
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=195aa19a6c9b7c5bd86a0961259209e9b24411e9;p=systemd.git

login: add a missing error check for session_set_leader()

session_set_leader() may fail. If it fails, then manager_start_scope()
will trigger assertion.

This may be related to RHBZ#1663704.

(cherry picked from commit fe3ab8458b9c0ead4b3e14ac25b342d8c34376fe)

Gbp-Pq: Name login-add-a-missing-error-check-for-session_set_leader.patch
---

diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index 8ab498fd..b9ea370e 100644
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -790,7 +790,9 @@ static int method_create_session(sd_bus_message *message, void *userdata, sd_bus
                 goto fail;
 
         session_set_user(session, user);
-        session_set_leader(session, leader);
+        r = session_set_leader(session, leader);
+        if (r < 0)
+                goto fail;
 
         session->type = t;
         session->class = c;