From: Keir Fraser Date: Sat, 13 Dec 2008 17:44:20 +0000 (+0000) Subject: xenpmd: Fix bogus fgets() size parameter. X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~14026^2~24 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=158b608e1d8fed9e178367e20f831eb1d424f936;p=xen.git xenpmd: Fix bogus fgets() size parameter. Signed-off-by: Keir Fraser --- diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index c98e898316..28de744ef0 100644 --- a/tools/xenpmd/xenpmd.c +++ b/tools/xenpmd/xenpmd.c @@ -297,7 +297,6 @@ int get_next_battery_info_or_status(DIR *battery_dir, if ( !info_or_status ) return 0; - memset(line_info, 0, 256); if (type == BIF) memset(info_or_status, 0, sizeof(struct battery_info)); else @@ -307,11 +306,8 @@ int get_next_battery_info_or_status(DIR *battery_dir, if ( !file ) return 0; - while ( fgets(line_info, 1024, file) != NULL ) - { + while ( fgets(line_info, sizeof(line_info), file) != NULL ) parse_battery_info_or_status(line_info, type, info_or_status); - memset(line_info, 0, 256); - } fclose(file); return 1;