From: Keir Fraser Date: Mon, 22 Sep 2008 13:37:31 +0000 (+0100) Subject: Fix misc issues related to allowing support of more CPUs X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~14101^2~44 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=13fe69b4a731ddd43b27f888c0a7e79c55ff6c8a;p=xen.git Fix misc issues related to allowing support of more CPUs This mainly means removing stack variables that (should) depend on NR_CPUS (other than cpumask_t ones) and adjusting certain array sizes. There's at least one open tools issue: The 'xm vcpu-pin' path assumes a maximum of 64 CPU-s in many places. Signed-off-by: Jan Beulich --- diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 580707e947..8f20735805 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -96,7 +96,7 @@ int nmi_active; int __init check_nmi_watchdog (void) { - unsigned int prev_nmi_count[NR_CPUS]; + static unsigned int __initdata prev_nmi_count[NR_CPUS]; int cpu; if ( !nmi_watchdog ) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index a09755feb9..69218fd322 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1121,7 +1121,7 @@ static void __init smp_boot_cpus(unsigned int max_cpus) Dprintk("CPU present map: %lx\n", physids_coerce(phys_cpu_present_map)); kicked = 1; - for (bit = 0; kicked < NR_CPUS && bit < MAX_APICS; bit++) { + for (bit = 0; kicked < NR_CPUS && bit < NR_CPUS; bit++) { apicid = cpu_present_to_apicid(bit); /* * Don't even attempt to start the boot CPU! diff --git a/xen/arch/x86/x86_32/domain_page.c b/xen/arch/x86/x86_32/domain_page.c index ff160c43e2..10f807b3e3 100644 --- a/xen/arch/x86/x86_32/domain_page.c +++ b/xen/arch/x86/x86_32/domain_page.c @@ -201,6 +201,9 @@ void *map_domain_page_global(unsigned long mfn) ASSERT(!in_irq() && local_irq_is_enabled()); + /* At least half the ioremap space should be available to us. */ + BUILD_BUG_ON(IOREMAP_VIRT_START + (IOREMAP_MBYTES << 19) >= FIXADDR_START); + spin_lock(&globalmap_lock); idx = find_next_zero_bit(inuse, GLOBALMAP_BITS, inuse_cursor); diff --git a/xen/common/domctl.c b/xen/common/domctl.c index bc19ac1fbc..9892550d8b 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -145,16 +145,23 @@ static unsigned int default_vcpu0_location(void) { struct domain *d; struct vcpu *v; - unsigned int i, cpu, cnt[NR_CPUS] = { 0 }; + unsigned int i, cpu, nr_cpus, *cnt; cpumask_t cpu_exclude_map; /* Do an initial CPU placement. Pick the least-populated CPU. */ - rcu_read_lock(&domlist_read_lock); - for_each_domain ( d ) - for_each_vcpu ( d, v ) - if ( !test_bit(_VPF_down, &v->pause_flags) ) - cnt[v->processor]++; - rcu_read_unlock(&domlist_read_lock); + nr_cpus = last_cpu(cpu_possible_map) + 1; + cnt = xmalloc_array(unsigned int, nr_cpus); + if ( cnt ) + { + memset(cnt, 0, nr_cpus * sizeof(*cnt)); + + rcu_read_lock(&domlist_read_lock); + for_each_domain ( d ) + for_each_vcpu ( d, v ) + if ( !test_bit(_VPF_down, &v->pause_flags) ) + cnt[v->processor]++; + rcu_read_unlock(&domlist_read_lock); + } /* * If we're on a HT system, we only auto-allocate to a non-primary HT. We @@ -172,10 +179,12 @@ static unsigned int default_vcpu0_location(void) (cpus_weight(cpu_sibling_map[i]) > 1) ) continue; cpus_or(cpu_exclude_map, cpu_exclude_map, cpu_sibling_map[i]); - if ( cnt[i] <= cnt[cpu] ) + if ( !cnt || cnt[i] <= cnt[cpu] ) cpu = i; } + xfree(cnt); + return cpu; } diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 6ecf208aa0..3ba7d3e8cd 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -1258,14 +1258,15 @@ csched_dump_pcpu(int cpu) struct csched_pcpu *spc; struct csched_vcpu *svc; int loop; + char cpustr[100]; spc = CSCHED_PCPU(cpu); runq = &spc->runq; - printk(" sort=%d, sibling=0x%lx, core=0x%lx\n", - spc->runq_sort_last, - cpu_sibling_map[cpu].bits[0], - cpu_core_map[cpu].bits[0]); + cpumask_scnprintf(cpustr, sizeof(cpustr), cpu_sibling_map[cpu]); + printk(" sort=%d, sibling=%s, ", spc->runq_sort_last, cpustr); + cpumask_scnprintf(cpustr, sizeof(cpustr), cpu_core_map[cpu]); + printk("core=%s\n", cpustr); /* current VCPU */ svc = CSCHED_VCPU(per_cpu(schedule_data, cpu).curr); @@ -1292,6 +1293,7 @@ csched_dump(void) { struct list_head *iter_sdom, *iter_svc; int loop; + char idlers_buf[100]; printk("info:\n" "\tncpus = %u\n" @@ -1317,7 +1319,8 @@ csched_dump(void) CSCHED_TICKS_PER_TSLICE, CSCHED_TICKS_PER_ACCT); - printk("idlers: 0x%lx\n", csched_priv.idlers.bits[0]); + cpumask_scnprintf(idlers_buf, sizeof(idlers_buf), csched_priv.idlers); + printk("idlers: %s\n", idlers_buf); CSCHED_STATS_PRINTK(); diff --git a/xen/common/sched_sedf.c b/xen/common/sched_sedf.c index 7b4eafb632..4bf3c80a89 100644 --- a/xen/common/sched_sedf.c +++ b/xen/common/sched_sedf.c @@ -1298,8 +1298,18 @@ static int sedf_adjust_weights(struct xen_domctl_scheduler_op *cmd) { struct vcpu *p; struct domain *d; - int sumw[NR_CPUS] = { 0 }; - s_time_t sumt[NR_CPUS] = { 0 }; + unsigned int nr_cpus = last_cpu(cpu_possible_map) + 1; + int *sumw = xmalloc_array(int, nr_cpus); + s_time_t *sumt = xmalloc_array(s_time_t, nr_cpus); + + if ( !sumw || !sumt ) + { + xfree(sumt); + xfree(sumw); + return -ENOMEM; + } + memset(sumw, 0, nr_cpus * sizeof(*sumw)); + memset(sumt, 0, nr_cpus * sizeof(*sumt)); /* Sum across all weights. */ rcu_read_lock(&domlist_read_lock); @@ -1348,6 +1358,9 @@ static int sedf_adjust_weights(struct xen_domctl_scheduler_op *cmd) } rcu_read_unlock(&domlist_read_lock); + xfree(sumt); + xfree(sumw); + return 0; } @@ -1356,6 +1369,7 @@ static int sedf_adjust_weights(struct xen_domctl_scheduler_op *cmd) static int sedf_adjust(struct domain *p, struct xen_domctl_scheduler_op *op) { struct vcpu *v; + int rc; PRINT(2,"sedf_adjust was called, domain-id %i new period %"PRIu64" " "new slice %"PRIu64"\nlatency %"PRIu64" extra:%s\n", @@ -1411,8 +1425,9 @@ static int sedf_adjust(struct domain *p, struct xen_domctl_scheduler_op *op) } } - if ( sedf_adjust_weights(op) ) - return -EINVAL; + rc = sedf_adjust_weights(op); + if ( rc ) + return rc; for_each_vcpu ( p, v ) {