From: Eirik Aavitsland Date: Wed, 11 Mar 2015 08:00:41 +0000 (+0100) Subject: Fixes crash in gif image decoder X-Git-Tag: archive/raspbian/4%4.8.6+git64-g5dc8b2b+dfsg-3+deb8u2+rpi1~48 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=131c432c9c2b7cf5b3b0c2b893dd45ede54a3ca6;p=qt4-x11.git Fixes crash in gif image decoder Fuzzing test revealed that for certain malformed gif files, qgifhandler would segfault. Change-Id: I5bb6f60e1c61849e0d8c735edc3869945e5331c1 (cherry picked from qtbase/ea2c5417fcd374302f5019e67f72af5facbd29f6) Reviewed-by: Richard J. Moore Gbp-Pq: Name fixes_crash_in_gif_image_decoder.patch --- diff --git a/src/gui/image/qgifhandler.cpp b/src/gui/image/qgifhandler.cpp index 6540f8aec..bcdc80269 100644 --- a/src/gui/image/qgifhandler.cpp +++ b/src/gui/image/qgifhandler.cpp @@ -951,6 +951,8 @@ void QGIFFormat::fillRect(QImage *image, int col, int row, int w, int h, QRgb co void QGIFFormat::nextY(unsigned char *bits, int bpl) { + if (out_of_bounds) + return; int my; switch (interlace) { case 0: // Non-interlaced