From: Ian Campbell Date: Wed, 19 Nov 2014 15:28:13 +0000 (+0000) Subject: xen: arm: correct off by one in xgene-storm's map_one_mmio X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~4074 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=0f25d1b324b7922094c9e1bde78d7df01d57dadc;p=xen.git xen: arm: correct off by one in xgene-storm's map_one_mmio The callers pass the end as the pfn immediately *after* the last page to be mapped, therefore adding one is incorrect and causes an additional page to be mapped. At the same time correct the printing of the mfn values, zero-padding them to 16 digits as for a paddr when they are frame numbers is just confusing. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall --- diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index 29c47523b1..8685c932b3 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -45,11 +45,11 @@ static int map_one_mmio(struct domain *d, const char *what, { int ret; - printk("Additional MMIO %"PRIpaddr"-%"PRIpaddr" (%s)\n", + printk("Additional MMIO %lx-%lx (%s)\n", start, end, what); - ret = map_mmio_regions(d, start, end - start + 1, start); + ret = map_mmio_regions(d, start, end - start, start); if ( ret ) - printk("Failed to map %s @ %"PRIpaddr" to dom%d\n", + printk("Failed to map %s @ %lx to dom%d\n", what, start, d->domain_id); return ret; }