From: Joseph Marrero Corchado <jmarrero@redhat.com>
Date: Wed, 5 Aug 2026 23:49:42 +0000 (-0400)
Subject: tests: Fix flaky kola destructive tests
X-Git-Tag: archive/raspbian/2026.4-1+rpi1^2~9^2^2~4^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=0efe2e8e131834f760dd8798a073058e14adcd74;p=ostree.git

tests: Fix flaky kola destructive tests

The kargs-proc-cmdline-quoted test was parsing `ostree admin status`
text output with a sed regex that assumes the line ends with the
deployment serial.  Status annotations like "(pending)" break this;
just reuse $host_commit from libinsttest.sh instead.

For soft-reboot, make the initramfs regeneration check non-fatal
since dracut can fail inside bwrap in CI VMs.  The kargs-based
kernel state check still covers the same rejection path.
---

diff --git a/tests/kolainst/destructive/kargs-proc-cmdline-quoted.sh b/tests/kolainst/destructive/kargs-proc-cmdline-quoted.sh
index 32d8d1f9..7ee28561 100755
--- a/tests/kolainst/destructive/kargs-proc-cmdline-quoted.sh
+++ b/tests/kolainst/destructive/kargs-proc-cmdline-quoted.sh
@@ -34,7 +34,9 @@ case "${AUTOPKGTEST_REBOOT_MARK:-}" in
   ostree admin instutil set-kargs --import-proc-cmdline
   echo "ok import-proc-cmdline with quoted kargs"
 
-  host_commit=$(ostree admin status | sed -n 's/^.* \(.*\)\.0$/\1/p' | head -1)
+  # Use $host_commit from libinsttest.sh (set via rpm-ostree status --json).
+  # Don't parse "ostree admin status" text output -- status annotations like
+  # "(pending)" after the serial break naive regexes.
   ostree admin deploy --karg-proc-cmdline "${host_commit}"
   echo "ok deploy --karg-proc-cmdline with quoted kargs"
   ;;
diff --git a/tests/kolainst/destructive/soft-reboot.sh b/tests/kolainst/destructive/soft-reboot.sh
index 1b883d52..ba1c5c5e 100755
--- a/tests/kolainst/destructive/soft-reboot.sh
+++ b/tests/kolainst/destructive/soft-reboot.sh
@@ -174,14 +174,18 @@ case "${AUTOPKGTEST_REBOOT_MARK:-}" in
   echo "ok soft reboot to non-staged"
 
   # We can't soft reboot into a changed kernel state
-  rpm-ostree initramfs --enable
-  if ostree admin prepare-soft-reboot 0 2>err.txt; then
-    fatal "soft reboot prep with kernel change"
+  if rpm-ostree initramfs --enable; then
+    if ostree admin prepare-soft-reboot 0 2>err.txt; then
+      fatal "soft reboot prep with kernel change"
+    fi
+    assert_file_has_content_literal err.txt "different kernel state"
+    rm -vf err.txt
+
+    rpm-ostree cleanup -p
+    echo "ok soft reboot rejected for initramfs change"
+  else
+    echo "warning: rpm-ostree initramfs --enable failed (dracut issue); skipping initramfs kernel-state check"
   fi
-  assert_file_has_content_literal err.txt "different kernel state"
-  rm -vf err.txt
-
-  rpm-ostree cleanup -p
 
   rpm-ostree kargs --append=foo=bar
   if ostree admin prepare-soft-reboot 0 2>err.txt; then