From: Xenia Ragiadakou <burzalodowa@gmail.com>
Date: Mon, 18 Jul 2022 15:56:41 +0000 (+0200)
Subject: sched/credit: fix MISRA C 2012 Rule 8.7 violation
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~424
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=0e60f1d9d1970cae49ee9d03f5759f44afc1fdee;p=xen.git

sched/credit: fix MISRA C 2012 Rule 8.7 violation

The per-cpu variable last_tickle_cpu is referenced only in credit.c.
Change its linkage from external to internal by adding the storage-class
specifier static to its definitions.

Also, this patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation
warning.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---

diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index 4d3bd8cba6..47945c2834 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -348,7 +348,7 @@ static void burn_credits(struct csched_unit *svc, s_time_t now)
 static bool __read_mostly opt_tickle_one_idle = true;
 boolean_param("tickle_one_idle_cpu", opt_tickle_one_idle);
 
-DEFINE_PER_CPU(unsigned int, last_tickle_cpu);
+static DEFINE_PER_CPU(unsigned int, last_tickle_cpu);
 
 static inline void __runq_tickle(const struct csched_unit *new)
 {