From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Wed, 18 Jun 2014 17:44:44 +0000 (+0100)
Subject: tools/libxc: Fix missing break in xc_domain_bind_pt_irq()
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~4802
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=0c615f8dadb4389048d574abd1515861d3f8403f;p=xen.git

tools/libxc: Fix missing break in xc_domain_bind_pt_irq()

c/s 568da4f8 "pt-irq fixes and improvements" accidentally forgot a break when
refactoring xc_domain_bind_pt_irq() which results in bind->u.pci.bus being
clobbered by isa_irq for PCI and MSI_TRANSLATE interrupts.

Coverity-ID: 1223210
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
---

diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index ef470a5ba1..d5d6d12f74 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1711,6 +1711,7 @@ int xc_domain_bind_pt_irq(
         bind->u.pci.bus = bus;
         bind->u.pci.device = device;
         bind->u.pci.intx = intx;
+        break;
     case PT_IRQ_TYPE_ISA:
         bind->u.isa.isa_irq = isa_irq;
         break;