From: DJ Delorie <dj@redhat.com>
Date: Thu, 25 Feb 2021 21:08:21 +0000 (-0500)
Subject: [PATCH] nscd: Fix double free in netgroupcache [BZ #27462]
X-Git-Tag: archive/raspbian/2.28-10+rpi1+deb10u2^2~5
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=06d0610cbe02e95ea623cc9a94bd0bd7d4dacc5e;p=glibc.git

[PATCH] nscd: Fix double free in netgroupcache [BZ #27462]

In commit 745664bd798ec8fd50438605948eea594179fba1 a use-after-free
was fixed, but this led to an occasional double-free.  This patch
tracks the "live" allocation better.

Tested manually by a third party.

Related: RHBZ 1927877

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>


Gbp-Pq: Topic all
Gbp-Pq: Name git-CVE-2021-27645-nscd-Fix-double-free-in-netgroupcache-BZ-27462.diff
---

diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c
index 87059fb28..c89629aec 100644
--- a/nscd/netgroupcache.c
+++ b/nscd/netgroupcache.c
@@ -248,7 +248,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req,
 					     : NULL);
 				    ndomain = (ndomain ? newbuf + ndomaindiff
 					       : NULL);
-				    buffer = newbuf;
+				    *tofreep = buffer = newbuf;
 				  }
 
 				nhost = memcpy (buffer + bufused,
@@ -319,7 +319,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req,
 		    else if (status == NSS_STATUS_TRYAGAIN && e == ERANGE)
 		      {
 			buflen *= 2;
-			buffer = xrealloc (buffer, buflen);
+			*tofreep = buffer = xrealloc (buffer, buflen);
 		      }
 		    else if (status == NSS_STATUS_RETURN
 			     || status == NSS_STATUS_NOTFOUND