From: Xenia Ragiadakou Date: Fri, 29 Jul 2022 06:51:31 +0000 (+0200) Subject: arm/atomic: fix MISRA C 2012 Rule 20.7 violation X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~366 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=062790aca6b1faea62c9ed2737c3791efb0d0f4c;p=xen.git arm/atomic: fix MISRA C 2012 Rule 20.7 violation The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index ac2798d095..1f60c28b1b 100644 --- a/xen/arch/arm/include/asm/atomic.h +++ b/xen/arch/arm/include/asm/atomic.h @@ -123,15 +123,15 @@ static always_inline void write_atomic_size(volatile void *p, } #define read_atomic(p) ({ \ - union { typeof(*p) val; char c[0]; } x_; \ - read_atomic_size(p, x_.c, sizeof(*p)); \ + union { typeof(*(p)) val; char c[0]; } x_; \ + read_atomic_size(p, x_.c, sizeof(*(p))); \ x_.val; \ }) #define write_atomic(p, x) \ do { \ - typeof(*p) x_ = (x); \ - write_atomic_size(p, &x_, sizeof(*p)); \ + typeof(*(p)) x_ = (x); \ + write_atomic_size(p, &x_, sizeof(*(p))); \ } while ( false ) #define add_sized(p, x) ({ \