From: Joey Hess Date: Wed, 18 Nov 2020 19:16:49 +0000 (-0400) Subject: update X-Git-Tag: archive/raspbian/10.20250416-2+rpi1~2^2^2~80^2~56^2 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=043eee0cb5f9f9fb2e0b4546912296f7cda4da98;p=git-annex.git update --- diff --git a/CHANGELOG b/CHANGELOG index edef6eb3d7..fe32908de6 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -9,6 +9,9 @@ git-annex (8.20201117) UNRELEASED; urgency=medium and for easier scripting. * init: When writing hook scripts, set all execute bits, not only the user execute bit. + * Fix hang when an external special remote program exited but + the stderr pipe to it was left open, due to a daemon having inherited + the file descriptor. -- Joey Hess Mon, 16 Nov 2020 09:38:32 -0400 diff --git a/doc/bugs/Buggy_external_special_remote_stalls_after_7245a9e/comment_4_746ffcf575f91bc3d156b279bcdf8ae2._comment b/doc/bugs/Buggy_external_special_remote_stalls_after_7245a9e/comment_4_746ffcf575f91bc3d156b279bcdf8ae2._comment new file mode 100644 index 0000000000..f4fc122825 --- /dev/null +++ b/doc/bugs/Buggy_external_special_remote_stalls_after_7245a9e/comment_4_746ffcf575f91bc3d156b279bcdf8ae2._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 4""" + date="2020-11-18T17:23:21Z" + content=""" +Seems the problem with hWaitForInput happens when running it concurrently +with hGetLine on the same handle. When I run it sequentially, it does seem +to work. Ok.. I was able to implement hGetLineUntilExitOrEOF that seems to +work. + +I've converted it to use that, and the test case for this bug is fixed. +Also, the sleep based workaround +in [[!commit aa492bc65904a19f22ffdfc20d7a5e7052e2f54d]] is removed, +and it uses hGetLineUntilExitOrEOF instead. + +However, I still want to do the audit of other things that pipe stderr. +Some of them don't do line based input, so will need a different function +than hGetLineUntilExitOrEOF. Leaving this bug open until that audit is +done. +"""]]