From: Wei Liu <wei.liu2@citrix.com>
Date: Fri, 29 Apr 2016 15:11:15 +0000 (+0100)
Subject: blktap2: initialise buf in vhd_util_check_footer
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1150
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=01120b223aba0af46d482ac679c467d39d9cad7d;p=xen.git

blktap2: initialise buf in vhd_util_check_footer

Gcc complains:

vhd-util-check.c: In function ‘vhd_util_check_footer’:
vhd-util-check.c:413:2: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  memcpy(&backup, buf, sizeof(backup));

In fact buf is initialised a few lines above.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
---

diff --git a/tools/blktap2/vhd/lib/vhd-util-check.c b/tools/blktap2/vhd/lib/vhd-util-check.c
index af07426d5b..40565ac233 100644
--- a/tools/blktap2/vhd/lib/vhd-util-check.c
+++ b/tools/blktap2/vhd/lib/vhd-util-check.c
@@ -335,7 +335,7 @@ vhd_util_check_footer(int fd, vhd_footer_t *footer, int ignore)
 {
 	size_t size;
 	int err, opened;
-	char *msg, *buf;
+	char *msg, *buf = NULL;
 	off_t eof, off;
 	vhd_footer_t primary, backup;