x86/hvm: prevent gcc uninitialised var warning
authorDon Slutz <dslutz@verizon.com>
Mon, 23 Mar 2015 15:53:44 +0000 (16:53 +0100)
committerJan Beulich <jbeulich@suse.com>
Mon, 23 Mar 2015 15:53:44 +0000 (16:53 +0100)
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 reports:
----------------------------------------------------------------------
hvm.c: In function `hvm_create_ioreq_server':
hvm.c:487:18: error: `bufioreq_pfn' may be used uninitialised in this function
[-Werror=uninitialized]
hvm.c:718:30: note: `bufioreq_pfn' was declared here
----------------------------------------------------------------------

My code analysis says that gcc is wrong, but initilize the variable
to prevent the gcc warning.

Reported-by: Ian Murray <murrayie@yahoo.co.uk>
Signed-off-by: Don Slutz <dslutz@verizon.com>
xen/arch/x86/hvm/hvm.c

index 4734d7112f7b8b72519c2ce5984152e3d3d5735d..dd6b0d0e3d481b945412c717e2bbfb20ddd6f9bc 100644 (file)
@@ -733,7 +733,8 @@ static int hvm_ioreq_server_map_pages(struct hvm_ioreq_server *s,
                                       bool_t is_default, bool_t handle_bufioreq)
 {
     struct domain *d = s->domain;
-    unsigned long ioreq_pfn, bufioreq_pfn;
+    unsigned long ioreq_pfn;
+    unsigned long bufioreq_pfn = ~0UL; /* gcc uninitialised var warning */
     int rc;
 
     if ( is_default )