Don't emit ::notify from a getter
authorMatthias Clasen <mclasen@redhat.com>
Sun, 27 Nov 2022 02:53:33 +0000 (21:53 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Sun, 27 Nov 2022 02:53:33 +0000 (21:53 -0500)
GdkX11Keymap ddetermines the direction of the
keymap on demand, and was emitting notify::direction

gdk/x11/gdkkeys-x11.c

index 904735783603f8b15415206eda36ae5a92f3c7c7..ec626010148c9b4f85170c85b484844e9101e666 100644 (file)
@@ -603,7 +603,7 @@ update_direction (GdkX11Keymap *keymap_x11,
       keymap_x11->have_direction = TRUE;
     }
 
-  if (!had_direction || old_direction != keymap_x11->current_direction)
+  if (had_direction && old_direction != keymap_x11->current_direction)
     {
       g_object_notify (G_OBJECT (keyboard), "direction");
       return TRUE;