histedit-ncurses

# HG changeset patch
# User Julien Cristau <jcristau@mozilla.com>
# Date 1702378068 -3600
#      Tue Dec 12 11:47:48 2023 +0100
# Branch stable
# Node ID e306d552dfb126efec571c5834400c84809c7efb
# Parent  cde293e04ca05ca8e324d9640b73b3056bfb0033
# EXP-Topic histedit-endwin
histedit: remove superfluous echo() and endwin() calls (issue6859)

ncurses patchlevel 20231111 started returning an error from endwin() if
called twice without a intervening screen update.

Per Sven Joachim in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058041#17: "AFAICS,
invoking curses.echo() and curses.endwin() is superfluous
because curses.wrapper already does that for you, and calling
curses.endwin() twice throws an error with the newer ncurses.  Removing
those two lines should fix the problem."

Gbp-Pq: Name histedit-ncurses.patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
index 384112cc8e0783535d9ab172c752efef0e5d4440..d17f4d05a5e1e3db9f6a2c03d58c502cce0fc5cc 100644 (file)
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -1760,8 +1760,6 @@ def _chistedit(ui, repo, freeargs, opts):
             rules.append(histeditrule(ui, repo[r], i))
         with util.with_lc_ctype():
             rc = curses.wrapper(functools.partial(_chisteditmain, repo, rules))
-        curses.echo()
-        curses.endwin()
         if rc is False:
             ui.write(_(b"histedit aborted\n"))
             return 0