Clazy: Fix some warnings

diff --git a/src/libsync/discoveryphase.cpp b/src/libsync/discoveryphase.cpp
index 51e0e15fd39b99fd3ecd1c3885844215142fc01c..24090197f9ad0491c46bcb9e89fd70c5efcddadf 100644 (file)
--- a/src/libsync/discoveryphase.cpp
+++ b/src/libsync/discoveryphase.cpp
@@ -141,7 +141,7 @@ QString DiscoveryPhase::adjustRenamedPath(const QString &original, SyncFileItem:
     return OCC::adjustRenamedPath(d == SyncFileItem::Down ? _renamedItemsRemote : _renamedItemsLocal, original);
 }
 
-QString adjustRenamedPath(const QMap<QString, QString> renamedItems, const QString original)
+QString adjustRenamedPath(const QMap<QString, QString> &renamedItems, const QString &original)
 {
     int slashPos = original.size();
     while ((slashPos = original.lastIndexOf('/', slashPos - 1)) > 0) {
@@ -420,7 +420,7 @@ static void propertyMapToRemoteInfo(const QMap<QString, QString> &map, RemoteInf
     }
 }
 
-void DiscoverySingleDirectoryJob::directoryListingIteratedSlot(QString file, const QMap<QString, QString> &map)
+void DiscoverySingleDirectoryJob::directoryListingIteratedSlot(const QString &file, const QMap<QString, QString> &map)
 {
     if (!_ignoredFirst) {
         // The first entry is for the folder itself, we should process it differently.
@@ -493,7 +493,6 @@ void DiscoverySingleDirectoryJob::lsJobFinishedWithErrorSlot(QNetworkReply *r)
 {
     QString contentType = r->header(QNetworkRequest::ContentTypeHeader).toString();
     int httpCode = r->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
-    QString httpReason = r->attribute(QNetworkRequest::HttpReasonPhraseAttribute).toString();
     QString msg = r->errorString();
     qCWarning(lcDiscovery) << "LSCOL job error" << r->errorString() << httpCode << r->error();
     if (r->error() == QNetworkReply::NoError

diff --git a/src/libsync/discoveryphase.h b/src/libsync/discoveryphase.h
index 5c6eabd2dfba0ffafd0837c99e02311ddddd73a7..6a8d1fa481130c22fc5960ecb7bb44255980377a 100644 (file)
--- a/src/libsync/discoveryphase.h
+++ b/src/libsync/discoveryphase.h
@@ -127,7 +127,7 @@ signals:
     void finished(const HttpResult<QVector<RemoteInfo>> &result);
 
 private slots:
-    void directoryListingIteratedSlot(QString, const QMap<QString, QString> &);
+    void directoryListingIteratedSlot(const QString &, const QMap<QString, QString> &);
     void lsJobFinishedWithoutErrorSlot();
     void lsJobFinishedWithErrorSlot(QNetworkReply *);
 
@@ -273,5 +273,5 @@ signals:
 };
 
 /// Implementation of DiscoveryPhase::adjustRenamedPath
-QString adjustRenamedPath(const QMap<QString, QString> renamedItems, const QString original);
+QString adjustRenamedPath(const QMap<QString, QString> &renamedItems, const QString &original);
 }