xen/drivers/acpi/tables.c: let custom parameter parsing routines return errno
authorJuergen Gross <jgross@suse.com>
Wed, 23 Aug 2017 17:34:00 +0000 (19:34 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 25 Aug 2017 14:19:26 +0000 (16:19 +0200)
Modify the custom parameter parsing routines in:

xen/drivers/acpi/tables.c

to indicate whether the parameter value was parsed successfully.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/drivers/acpi/tables.c

index dd2031f36af27f3df435c44918d9b12edf41d71f..b890b73901d338b5bf54fb1dc1dd3e74a9668130 100644 (file)
@@ -456,14 +456,15 @@ int __init acpi_table_init(void)
        return 0;
 }
 
-static int __init acpi_parse_apic_instance(char *str)
+static int __init acpi_parse_apic_instance(const char *str)
 {
+       const char *q;
 
-       acpi_apic_instance = simple_strtoul(str, NULL, 0);
+       acpi_apic_instance = simple_strtoul(str, &q, 0);
 
        printk(KERN_NOTICE PREFIX "Shall use APIC/MADT table %d\n",
               acpi_apic_instance);
 
-       return 0;
+       return *q ? -EINVAL : 0;
 }
 custom_param("acpi_apic_instance", acpi_parse_apic_instance);