xen/passthrough: x86: Use INVALID_GFN rather than INVALID_MFN
authorJulien Grall <julien.grall@arm.com>
Tue, 28 Jun 2016 12:31:32 +0000 (13:31 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 13 Jul 2016 13:08:04 +0000 (14:08 +0100)
A variable containing a guest frame should be compared to INVALID_GFN
and not INVALID_MFN.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
xen/drivers/passthrough/amd/iommu_map.c
xen/drivers/passthrough/x86/iommu.c

index 1b914bae1b583ec43eb90bcd0601f73cae62de6d..c7584591a3363d1449330e75fd5665f9c1a4f2cd 100644 (file)
@@ -555,7 +555,7 @@ static int update_paging_mode(struct domain *d, unsigned long gfn)
     unsigned long old_root_mfn;
     struct domain_iommu *hd = dom_iommu(d);
 
-    if ( gfn == INVALID_MFN )
+    if ( gfn == INVALID_GFN )
         return -EADDRNOTAVAIL;
     ASSERT(!(gfn >> DEFAULT_DOMAIN_ADDRESS_WIDTH));
 
index a18a6089127f694985192e362dbfd42e1bb41b84..cd435d7062fbdaa338f23759d43489d45ae04885 100644 (file)
@@ -61,7 +61,7 @@ int arch_iommu_populate_page_table(struct domain *d)
             unsigned long mfn = page_to_mfn(page);
             unsigned long gfn = mfn_to_gmfn(d, mfn);
 
-            if ( gfn != INVALID_MFN )
+            if ( gfn != INVALID_GFN )
             {
                 ASSERT(!(gfn >> DEFAULT_DOMAIN_ADDRESS_WIDTH));
                 BUG_ON(SHARED_M2P(gfn));