FolderWizard: fix crash in FolderWizardRemotePath::slotHandleLsColNetworkError
authorOlivier Goffart <ogoffart@woboq.com>
Fri, 28 Jul 2017 08:13:07 +0000 (10:13 +0200)
committerMarkus Goetz <markus@woboq.com>
Fri, 28 Jul 2017 09:57:08 +0000 (11:57 +0200)
The Job is a LsColJob, not a MkColJob!

Reproduce by entering a name with invalid character that cause an error 400
in the folder wizard's remote path line edit.

(Relates issue #5924)

src/gui/folderwizard.cpp

index 940cf8b3ac7d78b8c8cac36964aa4f7aaaffcd53..168f60d88a96e57165752cc3eca74a9f053deb8f 100644 (file)
@@ -22,6 +22,7 @@
 #include "accountstate.h"
 #include "creds/abstractcredentials.h"
 #include "wizard/owncloudwizard.h"
+#include "asserts.h"
 
 #include <QDesktopServices>
 #include <QDir>
@@ -229,7 +230,8 @@ void FolderWizardRemotePath::slotHandleMkdirNetworkError(QNetworkReply *reply)
 
 void FolderWizardRemotePath::slotHandleLsColNetworkError(QNetworkReply * /*reply*/)
 {
-    auto job = qobject_cast<MkColJob *>(sender());
+    auto job = qobject_cast<LsColJob *>(sender());
+    ASSERT(job);
     showWarn(tr("Failed to list a folder. Error: %1")
                  .arg(job->errorStringParsingBody()));
 }