widget: Take a ref during ::unmap emission
authorCarlos Garnacho <carlosg@gnome.org>
Mon, 16 Mar 2015 12:45:03 +0000 (13:45 +0100)
committerCarlos Garnacho <carlosg@gnome.org>
Mon, 16 Mar 2015 15:22:25 +0000 (16:22 +0100)
This ensures the widget data stays live long enough to perform invariants
check after emission if the widget happens to be destroyed on a callback.

https://bugzilla.gnome.org/show_bug.cgi?id=745829

gtk/gtkwidget.c

index 0e9ed8275025395d68a6efac2a03ccdc1e15bc28..043fac48bf20df0072c181184558138d4c92f6bb 100644 (file)
@@ -5081,6 +5081,7 @@ gtk_widget_unmap (GtkWidget *widget)
 
   if (gtk_widget_get_mapped (widget))
     {
+      g_object_ref (widget);
       gtk_widget_push_verify_invariants (widget);
 
       if (!gtk_widget_get_has_window (widget))
@@ -5093,6 +5094,7 @@ gtk_widget_unmap (GtkWidget *widget)
       g_signal_emit (widget, widget_signals[UNMAP], 0);
 
       gtk_widget_pop_verify_invariants (widget);
+      g_object_unref (widget);
     }
 }