promote comment to bug
authorJoey Hess <joeyh@joeyh.name>
Mon, 27 Mar 2023 18:10:32 +0000 (14:10 -0400)
committerJoey Hess <joeyh@joeyh.name>
Mon, 27 Mar 2023 18:10:32 +0000 (14:10 -0400)
doc/bugs/securehashesonly_conflicts_with_addurl.mdwn [new file with mode: 0644]
doc/bugs/securehashesonly_conflicts_with_addurl/comment_1_808e276381f98b4ebb7d61628db703d9._comment [new file with mode: 0644]
doc/git-annex-addurl/comment_16_c6e1743647bb4d45b5a1b237f53d77a6._comment [new file with mode: 0644]

diff --git a/doc/bugs/securehashesonly_conflicts_with_addurl.mdwn b/doc/bugs/securehashesonly_conflicts_with_addurl.mdwn
new file mode 100644 (file)
index 0000000..d98d545
--- /dev/null
@@ -0,0 +1,15 @@
+Turning on `securehashesonly` seems to disable the `addurl` command:
+
+```console
+% git config --get annex.securehashesonly
+true
+% git annex addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html
+addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html
+  annex.securehashesonly blocked transfer of URL key
+failed
+addurl: 1 failed
+% git annex addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html --relaxed
+addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html (to www.gutenberg.org_cache_epub_2591_pg2591-images.html) ok
+(recording state in git...)
+% ls -l www.gutenberg.org_cache_epub_2591_pg2591-images.html
+www.gutenberg.org_cache_epub_2591_pg2591-images.html -> .git/annex/objects/gg/kG/URL--https&c%%www.gutenberg.org%cache%epub%2591%pg2591-images.html/URL--https&c%%www.gutenberg.org%cache%epub%2591%pg2591-images.html
diff --git a/doc/bugs/securehashesonly_conflicts_with_addurl/comment_1_808e276381f98b4ebb7d61628db703d9._comment b/doc/bugs/securehashesonly_conflicts_with_addurl/comment_1_808e276381f98b4ebb7d61628db703d9._comment
new file mode 100644 (file)
index 0000000..bf5ae10
--- /dev/null
@@ -0,0 +1,18 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2023-03-27T18:03:11Z"
+ content="""
+I think that git-annex addurl without --fast or --relaxed should
+work with annex.securehashesonly set. (Unless annex.backend is set 
+to something it prevents adding.) It is currently failing because
+of a temporary URL key that never reaches the repository. So the check
+should be disabled for that.
+
+Arguably with --relaxed (or --fast) it should also fail. However,
+that does not actually download the content, so it does not technically
+add content to the repository that is not using a cryptographically
+signed hash. That's how it manages to skate by without failing.
+Of course git-annex get will later fail, git-annex fsck 
+will complain, etc.
+"""]]
diff --git a/doc/git-annex-addurl/comment_16_c6e1743647bb4d45b5a1b237f53d77a6._comment b/doc/git-annex-addurl/comment_16_c6e1743647bb4d45b5a1b237f53d77a6._comment
new file mode 100644 (file)
index 0000000..78b1fb9
--- /dev/null
@@ -0,0 +1,7 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""Re: securehashesonly conflicts with addurl"""
+ date="2023-03-27T17:59:35Z"
+ content="""
+Opened a bug report: [[bugs/securehashesonly_conflicts_with_addurl]]
+"""]]