x11: Don't try to move destroyed windows
authorBenjamin Otte <otte@redhat.com>
Mon, 11 Oct 2021 17:22:46 +0000 (19:22 +0200)
committerBenjamin Otte <otte@redhat.com>
Mon, 11 Oct 2021 17:28:59 +0000 (19:28 +0200)
Fixes BadWindow crashes when the resize happen right when tooltips or
other such transient popups were in the process of being destroyed.

gdk/x11/gdksurface-x11.c

index 16e1a3678d5c369afc19d458fb2402e9ade65c54..4e2c2e9e1134c7aa83dfc84a39e9b6228c4ea858 100644 (file)
@@ -1926,8 +1926,13 @@ gdk_x11_surface_update_popups (GdkSurface *parent)
     {
       GdkX11Surface *popup_impl = l->data;
       GdkSurface *popup = GDK_SURFACE (popup_impl);
-      int new_x = GDK_X11_SURFACE (parent)->abs_x + popup->x;
-      int new_y = GDK_X11_SURFACE (parent)->abs_y + popup->y;
+      int new_x, new_y;
+
+      if (GDK_SURFACE_DESTROYED (popup))
+        continue;
+
+      new_x = GDK_X11_SURFACE (parent)->abs_x + popup->x;
+      new_y = GDK_X11_SURFACE (parent)->abs_y + popup->y;
 
       if (new_x != popup_impl->abs_x || new_y != popup_impl->abs_y)
         x11_surface_move (popup, new_x, new_y);