initialize all variables

done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-init-variables' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

diff --git a/src/3rdparty/kirigami/wheelhandler.cpp b/src/3rdparty/kirigami/wheelhandler.cpp
index 9dacae4db080b8599d6bdde8753cadb8c689f897..7821b64f9385d2d93ab2de739f4c1269de50690c 100644 (file)
--- a/src/3rdparty/kirigami/wheelhandler.cpp
+++ b/src/3rdparty/kirigami/wheelhandler.cpp
@@ -351,8 +351,8 @@ bool WheelHandler::scrollFlickable(QPointF pixelDelta, QPointF angleDelta, Qt::K
 
     const qreal xTicks = angleDelta.x() / 120;
     const qreal yTicks = angleDelta.y() / 120;
-    qreal xChange;
-    qreal yChange;
+    qreal xChange = NAN;
+    qreal yChange = NAN;
     bool scrolled = false;
 
     // Scroll X

diff --git a/src/gui/cloudproviders/cloudprovidermanager.cpp b/src/gui/cloudproviders/cloudprovidermanager.cpp
index 8f632c18e220d2e8c57a6c2290940946a9723b1f..35ff2a5c8405112c8bf5d9b51b5294f3a89a29d0 100644 (file)
--- a/src/gui/cloudproviders/cloudprovidermanager.cpp
+++ b/src/gui/cloudproviders/cloudprovidermanager.cpp
@@ -26,7 +26,7 @@ CloudProvidersProviderExporter *_providerExporter;
 void on_name_acquired (GDBusConnection *connection, const gchar *name, gpointer user_data)
 {
     Q_UNUSED(name);
-    CloudProviderManager *self;
+    CloudProviderManager *self = nullptr;
     self = static_cast<CloudProviderManager*>(user_data);
     _providerExporter = cloud_providers_provider_exporter_new(connection, LIBCLOUDPROVIDERS_DBUS_BUS_NAME, LIBCLOUDPROVIDERS_DBUS_OBJECT_PATH);
     cloud_providers_provider_exporter_set_name (_providerExporter, APPLICATION_NAME);

diff --git a/src/gui/cloudproviders/cloudproviderwrapper.cpp b/src/gui/cloudproviders/cloudproviderwrapper.cpp
index 04ae01c85af04283139ea931d849da5525e60f45..bbf65876b4f6fb7fa4467f8d1a4a9efa90099507 100644 (file)
--- a/src/gui/cloudproviders/cloudproviderwrapper.cpp
+++ b/src/gui/cloudproviders/cloudproviderwrapper.cpp
@@ -34,8 +34,8 @@ GSimpleActionGroup *actionGroup = nullptr;
 CloudProviderWrapper::CloudProviderWrapper(QObject *parent, Folder *folder, int folderId, CloudProvidersProviderExporter* cloudprovider) : QObject(parent)
   , _folder(folder)
 {
-    GMenuModel *model;
-    GActionGroup *action_group;
+    GMenuModel *model = nullptr;
+    GActionGroup *action_group = nullptr;
     QString accountName = QString("Folder/%1").arg(folderId);
 
     _cloudProvider = CLOUD_PROVIDERS_PROVIDER_EXPORTER(cloudprovider);
@@ -147,7 +147,7 @@ void CloudProviderWrapper::slotUpdateProgress(const QString &folder, const Progr
 
     if (!progress._lastCompletedItem.isEmpty()
             && shouldShowInRecentsMenu(progress._lastCompletedItem)) {
-        GMenuItem* item;
+        GMenuItem* item = nullptr;
         g_menu_remove_all (G_MENU(_recentMenu));
         if(!_recentlyChanged.isEmpty()) {
             QList<QPair<QString, QString>>::iterator i;
@@ -208,8 +208,8 @@ void CloudProviderWrapper::slotSyncFinished(const SyncResult &result)
 
 GMenuModel* CloudProviderWrapper::getMenuModel() {
 
-    GMenu* section;
-    GMenuItem* item;
+    GMenu* section = nullptr;
+    GMenuItem* item = nullptr;
     QString item_label;
 
     _mainMenu = g_menu_new();
@@ -314,7 +314,7 @@ activate_action_pause (GSimpleAction *action,
 {
     Q_UNUSED(parameter);
     auto *self = static_cast<CloudProviderWrapper*>(user_data);
-    GVariant *old_state, *new_state;
+    GVariant *old_state = nullptr, *new_state = nullptr;
 
     old_state = g_action_get_state (G_ACTION (action));
     new_state = g_variant_new_boolean (!(bool)g_variant_get_boolean (old_state));

diff --git a/test/teste2efiletransfer.cpp b/test/teste2efiletransfer.cpp
index 1722b026c7791c53e9335eed934fbb25dd9a3c50..aa6008a6a4ceac439c902f88c34c917053e29ce9 100644 (file)
--- a/test/teste2efiletransfer.cpp
+++ b/test/teste2efiletransfer.cpp
@@ -41,7 +41,7 @@ private slots:
     {
         {
             EndToEndTestHelper _helper;
-            OCC::Folder *_testFolder;
+            OCC::Folder *_testFolder = nullptr;
 
             QSignalSpy accountReady(&_helper, &EndToEndTestHelper::accountReady);
             _helper.startAccountConfig();