gtkdnd: Remove unnecessary call
authorCarlos Garnacho <carlosg@gnome.org>
Thu, 24 Nov 2016 15:24:04 +0000 (16:24 +0100)
committerCarlos Garnacho <carlosg@gnome.org>
Mon, 9 Jan 2017 18:04:23 +0000 (19:04 +0100)
drag-data-delete is emitted based on the interchange of the
DELETE atom, which may well be set or bypassed locally by
the app. As such emitting it here is not right, the other
paths handling the DELETE atom interchange are still valid
and there.

https://bugzilla.gnome.org/show_bug.cgi?id=774726

gtk/gtkdnd.c

index c9f34e2229c0cac002707ef5b14be1baeeee2084..2ed9b78140483487e862e373eac8abedbbeed689 100644 (file)
@@ -3030,13 +3030,6 @@ gtk_drag_context_dnd_finished_cb (GdkDragContext    *context,
                        info->proxy_dest->proxy_drop_time);
     }
 
-  if (gdk_drag_context_get_selected_action (context) == GDK_ACTION_MOVE)
-    {
-      g_signal_emit_by_name (info->widget,
-                             "drag-data-delete",
-                             context);
-    }
-
   gtk_drag_source_info_destroy (info);
 }