tdf#144037 Qt5 just close popup with mouse outside

How hard could it be to close a popup window when losing focus or
clicking outside of it (AKA tdf#143114 problem 3)? At least with
Qt it feels like solving an NP problem...

So don't always force-close the popup window if clicked anywhere
on it. Seems to be consistent with gen and gtk3.

Change-Id: Ia1c231c0b51a55bec2c587feffcf14bb4b4cee55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121093
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Gbp-Pq: Name qt5-fix-popups.diff

diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 864701340ad3d3a607c989791a112882fab97fe2..64ad4f7539c45b8a93b9904fcffc6c4b0a0447b1 100644 (file)
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -182,7 +182,7 @@ void Qt5Widget::mousePressEvent(QMouseEvent* pEvent)
 {
     handleMousePressEvent(m_rFrame, pEvent);
     if (m_rFrame.isPopup()
-        || !geometry().translated(geometry().topLeft() * -1).contains(pEvent->pos()))
+        && !geometry().translated(geometry().topLeft() * -1).contains(pEvent->pos()))
         closePopup();
 }