tools/pygrub: Failing to set value to 0 in Grub2ConfigFile
authorMichael Young <m.a.young@durham.ac.uk>
Tue, 13 Aug 2019 20:15:02 +0000 (21:15 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 14 Aug 2019 11:15:17 +0000 (12:15 +0100)
In Grub2ConfigFile the code to handle ${saved_entry} and ${next_entry}
sets arg = "0" but this now does nothing following c/s d1b93ea2615bd
"tools/pygrub: Make pygrub understand default entry in string format"
which replaced arg.strip() with arg_strip in the following line.  This
patch restores the previous behaviour.

Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
tools/pygrub/src/GrubConf.py

index 594139bac736995f987abd93fd4f15f9103d37f4..73f1bbed2f543333172104683768710ed61b6bf3 100644 (file)
@@ -440,7 +440,7 @@ class Grub2ConfigFile(_GrubConfigFile):
                     arg_strip = arg.strip()
                     if arg_strip == "${saved_entry}" or arg_strip == "${next_entry}":
                         logging.warning("grub2's saved_entry/next_entry not supported")
-                        arg = "0"
+                        arg_strip = "0"
                     setattr(self, self.commands[com], arg_strip)
                 else:
                     logging.info("Ignored directive %s" %(com,))