fir regression with VFS availability test on Windows
authorMatthieu Gallien <matthieu.gallien@nextcloud.com>
Thu, 28 Nov 2024 13:38:21 +0000 (14:38 +0100)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Fri, 29 Nov 2024 10:09:53 +0000 (10:09 +0000)
ensure we report the expected availability erro for non existing files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
src/libsync/vfs/cfapi/vfs_cfapi.cpp

index 64779407f2a9f3ac6782b87a56010dd4ad1fea13..27f8f945792af65603bb56709bb4b362f27a3193 100644 (file)
@@ -354,7 +354,7 @@ Vfs::AvailabilityResult VfsCfApi::availability(const QString &folderPath, const
             break;
         };
         return VfsItemAvailability::Mixed;
-    } else {
+    } else if (basePinState) {
         const auto hydrationAndPinStates = computeRecursiveHydrationAndPinStates(folderPath, basePinState);
 
         const auto pin = hydrationAndPinStates.pinState;
@@ -382,6 +382,8 @@ Vfs::AvailabilityResult VfsCfApi::availability(const QString &folderPath, const
             }
         }
         return AvailabilityError::NoSuchItem;
+    } else {
+        return AvailabilityError::NoSuchItem;
     }
 }