x86/pvh: initialize ioreq server for PVH guests
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Tue, 5 Apr 2016 11:25:13 +0000 (13:25 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 5 Apr 2016 11:25:13 +0000 (13:25 +0200)
ioreq server list needs to be initialized for PVH guests. This list is
walked in handle_hvm_io_completion() by all guests in HVM containers and
leaving it uninitialized may cause PVH guests to crash there.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/hvm/hvm.c
xen/arch/x86/hvm/ioreq.c

index ad14eb35ddd0d09d672dae803ba3b785669e6e0f..b239f74831a3c7a30e09ae38af56a2a0be546ecd 100644 (file)
@@ -621,6 +621,8 @@ int hvm_domain_initialise(struct domain *d)
 
     register_dpci_portio_handler(d);
 
+    hvm_ioreq_init(d);
+
     if ( is_pvh_domain(d) )
     {
         register_portio_handler(d, 0, 0x10003, handle_pvh_io);
@@ -645,8 +647,6 @@ int hvm_domain_initialise(struct domain *d)
 
     register_portio_handler(d, 0xe9, 1, hvm_print_line);
 
-    hvm_ioreq_init(d);
-
     if ( hvm_tsc_scaling_supported )
         d->arch.hvm_domain.tsc_scaling_ratio = hvm_default_tsc_scaling_ratio;
 
index e640eff45dee592501a6335e3621a7f252942cf2..690e4781c085fcb61c9d1556d6ab945d29820023 100644 (file)
@@ -1361,7 +1361,8 @@ void hvm_ioreq_init(struct domain *d)
     spin_lock_init(&d->arch.hvm_domain.ioreq_server.lock);
     INIT_LIST_HEAD(&d->arch.hvm_domain.ioreq_server.list);
 
-    register_portio_handler(d, 0xcf8, 4, hvm_access_cf8);
+    if ( !is_pvh_domain(d) )
+        register_portio_handler(d, 0xcf8, 4, hvm_access_cf8);
 }
 
 /*