adapt test-ci build target for buildd

Forwarded: not-needed
Reviewed-By: Xavier Guimard <yadd@debian.org>
Last-Update: 2020-02-09

* run tests with ./node
* remove addons from test-ci suite, because it creates a dependency loop
  nodejs -> node-gyp -> nodejs which is painful to manage.
* disabled because it requires stdin:
  + test-stdout-close-unref
  + test-regress-GH-746
* test-tick-processor fails on ppc64 and s390x, currently investigated
  https://github.com/nodejs/node/issues/2471
* test-cluster-disconnect sometimes fails on busy buildd, forwarded upstream
  https://github.com/nodejs/node/issues/3383
* test-fs-watch is flaky, might be related to https://github.com/nodejs/node/issues/4082
* huge timeout value for all platforms, buildd could be busy
* test-npm-install and test-release-npm must fail, debian package dfsg-repacked npm out
* ability to override CI_NATIVE_SUITES, CI_JS_SUITES
* disable tests failing because DNS is disabled
* sequential/test-http2-session-timeout is flaky https://github.com/nodejs/node/issues/20628

Gbp-Pq: Topic build
Gbp-Pq: Name test_ci.patch

diff --git a/Makefile b/Makefile
index 64ea805bf56e97e97369267546648bd753f07cd3..1455474a2d11c6d625dfcd038379daebc9c65011 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -502,7 +502,7 @@ test-ci-native: | benchmark/napi/.buildstamp test/addons/.buildstamp test/js-nat
 # This target should not use a native compiler at all
 # Related CI job: node-test-commit-arm-fanned
 test-ci-js: | clear-stalled
-       $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
+       $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap \
                --mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
                $(TEST_CI_ARGS) $(CI_JS_SUITES)
        $(info Clean up any leftover processes, error if found.)

diff --git a/test/common/index.js b/test/common/index.js
index c852dced52ee9f7043b51843cae5fa2049da8acb..52ee240f78892fcbb7c412ddd7340f54a67be265 100644 (file)
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -238,23 +238,14 @@ const pwdCommand = isWindows ?
 
 function platformTimeout(ms) {
   const multipliers = typeof ms === 'bigint' ?
-    { two: 2n, four: 4n, seven: 7n } : { two: 2, four: 4, seven: 7 };
+    { fast: 6n, slow: 12n } : { fast: 6, slow: 12 };
 
-  if (process.features.debug)
-    ms = multipliers.two * ms;
+  if (process.arch.startsWith('arm') || process.arch.startsWith('mips'))
+    ms = multipliers.slow * ms;
+  else
+    ms = multipliers.fast * ms;
 
-  if (isAIX)
-    return multipliers.two * ms; // Default localhost speed is slower on AIX
-
-  if (process.arch !== 'arm')
-    return ms;
-
-  const armv = process.config.variables.arm_version;
-
-  if (armv === '7')
-    return multipliers.two * ms;  // ARMv7
-
-  return ms; // ARMv8+
+  return ms;
 }
 
 let knownGlobals = [

diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
index 403752346856cd3846fc3d8f88ae1dc475ec2090..89ac8c694e694738fc2d715700ae71ee2a24681e 100644 (file)
--- a/test/parallel/parallel.status
+++ b/test/parallel/parallel.status
@@ -8,6 +8,45 @@ prefix parallel
 # https://github.com/nodejs/node/issues/41123
 test-repl-sigint-nested-eval: PASS, FLAKY
 
+test-process-config                  : PASS,FLAKY
+test-regress-GH-746                  : PASS,FLAKY
+test-stdout-close-unref              : PASS,FLAKY
+test-npm-install                     : FAIL
+test-npm-version                     : FAIL
+test-release-npm                     : FAIL
+# skip tests accessing network
+test-dns                             : SKIP
+test-net-connect-immediate-finish    : SKIP
+test-net-better-error-messages-port-hostname : SKIP
+
+# in debian build env, skip because it somehow tries to access network
+test-https-connect-address-family : SKIP 
+test-tls-connect-address-family : SKIP
+test-dns-cancel-reverse-lookup: SKIP
+
+# https://bugs.debian.org/919588
+## flaky on some user environments
+test-net-listen-after-destroying-stdin: PASS,FLAKY
+## fails when running with eatmydata
+test-fs-error-messages: PASS,FLAKY
+
+# this new test doesn't have a built target properly setup
+test-child-process-stdio-overlapped: SKIP
+
+# does not pass in autopkgtest ci env
+test-cluster-bind-privileged-port: PASS,FLAKY
+test-cluster-shared-handle-bind-privileged-port: PASS,FLAKY
+
+# corepack is dfsg-excluded
+test-corepack-yarn-install: SKIP
+test-corepack-version: SKIP
+
+# might fail, see https://github.com/nodejs/node/issues/17909
+test-fs-utimes: PASS,FLAKY
+
+# undici not yet available
+test-fetch: SKIP
+
 [$system==win32]
 # https://github.com/nodejs/node/issues/24497
 test-timers-immediate-queue: PASS,FLAKY
@@ -27,6 +66,10 @@ test-domain-error-types: PASS,FLAKY
 test-crypto-dh-stateless: SKIP
 test-crypto-keygen: SKIP
 
+[$arch==mips64el]
+# the debug flag is for hacking v8 internals
+test-debug-args: PASS,FLAKY
+
 [$system==solaris] # Also applies to SmartOS
 
 [$system==freebsd]

diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status
index 56f9667d7a30585cece8ebb0358b94fe284160f6..301405c53f843cc0f6ddb251b59005edb9f2aae7 100644 (file)
--- a/test/sequential/sequential.status
+++ b/test/sequential/sequential.status
@@ -8,6 +8,19 @@ prefix sequential
 # https://github.com/nodejs/node/issues/27611#issuecomment-613100468
 test-cpu-prof-dir-worker: PASS, FLAKY
 
+# flaky or failing at least on debian build servers
+test-fs-watch                                   : PASS,FLAKY
+test-force-repl                                 : SKIP
+test-performance                                : SKIP
+test-http2-session-timeout                      : PASS,FLAKY
+test-debugger-preserve-breaks                   : PASS,FLAKY
+
+# https://github.com/nodejs/node/issues/24403
+test-cli-syntax: PASS,FLAKY
+
+# for debian buildd i386 (but pass on porter barriere.d.o)
+test-debugger-heap-profiler: PASS,FLAKY
+
 [$system==win32]
 
 [$system==linux]

diff --git a/tools/test.py b/tools/test.py
index 9a7de5ed24d70648f22268101747290b0582a8a0..2126fb26ab1fbf2c3f77669ec436a863c2b5c16e 100755 (executable)
--- a/tools/test.py
+++ b/tools/test.py
@@ -922,25 +922,7 @@ class Context(object):
     self.node_has_crypto = True
 
   def GetVm(self, arch, mode):
-    if self.vm is not None:
-      return self.vm
-    if arch == 'none':
-      name = 'out/Debug/node' if mode == 'debug' else 'out/Release/node'
-    else:
-      name = 'out/%s.%s/node' % (arch, mode)
-
-    # Currently GYP does not support output_dir for MSVS.
-    # http://code.google.com/p/gyp/issues/detail?id=40
-    # It will put the builds into Release/node.exe or Debug/node.exe
-    if utils.IsWindows():
-      if not exists(name + '.exe'):
-        name = name.replace('out/', '')
-      name = os.path.abspath(name + '.exe')
-
-    if not exists(name):
-      raise ValueError('Could not find executable. Should be ' + name)
-
-    return name
+    return './node'
 
   def GetTimeout(self, mode, section=''):
     timeout = self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]